Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add limit= argument to Integer.prime_divisors() #35019

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Feb 8, 2023

Integer.factor() has an optional limit= argument to restrict the search to prime factors up to a certain size. This patch adds a similar argument to the .prime_divisors() method.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 88.60% // Head: 88.58% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (805b2de) compared to base (c000c95).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35019      +/-   ##
===========================================
- Coverage    88.60%   88.58%   -0.02%     
===========================================
  Files         2136     2140       +4     
  Lines       396142   396961     +819     
===========================================
+ Hits        350990   351660     +670     
- Misses       45152    45301     +149     
Impacted Files Coverage Δ
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
src/sage/modular/local_comp/liftings.py 98.33% <0.00%> (-1.67%) ⬇️
src/sage/combinat/combination.py 93.50% <0.00%> (-1.50%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.88% <0.00%> (-0.79%) ⬇️
src/sage/graphs/generators/random.py 91.95% <0.00%> (-0.69%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
src/sage/graphs/generic_graph.py 88.54% <0.00%> (-0.58%) ⬇️
src/sage/graphs/graph_plot.py 84.33% <0.00%> (-0.57%) ⬇️
src/sage/cpython/_py2_random.py 76.03% <0.00%> (-0.42%) ⬇️
src/sage/combinat/constellation.py 91.18% <0.00%> (-0.41%) ⬇️
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yyyyx4 yyyyx4 force-pushed the public/add_limit_argument_to_prime_divisors_method branch from 082d7c6 to 0f06092 Compare February 8, 2023 11:24
@edgarcosta
Copy link
Member

LGTM

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 805b2de

@yyyyx4
Copy link
Member Author

yyyyx4 commented Feb 16, 2023

Thank you!

@vbraun vbraun merged commit bbd91d3 into sagemath:develop Feb 24, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 24, 2023
@yyyyx4 yyyyx4 deleted the public/add_limit_argument_to_prime_divisors_method branch February 24, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants