Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark unstable tests in klyachko.py due to #32773 #35058

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

tornaria
Copy link
Contributor

📚 Description

These two test failures occasionally waste a whole CI run. Here we just flag them as random so it can be quickly merged, while #32773 is resolved. Since the issue is already known and reported, there is no point to keep running these tests.

Note that the issue in question has a needs_review patch but according to the comments it only solves one of the two tests.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.

@codecov-commenter
Copy link

Codecov Report

Base: 88.59% // Head: 88.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2df4448) compared to base (104dde9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35058      +/-   ##
===========================================
- Coverage    88.59%   88.58%   -0.01%     
===========================================
  Files         2136     2136              
  Lines       396142   396142              
===========================================
- Hits        350948   350911      -37     
- Misses       45194    45231      +37     
Impacted Files Coverage Δ
src/sage/schemes/toric/sheaf/klyachko.py 92.43% <ø> (ø)
src/sage/groups/affine_gps/euclidean_group.py 88.88% <0.00%> (-11.12%) ⬇️
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
src/sage/groups/affine_gps/affine_group.py 96.62% <0.00%> (-2.25%) ⬇️
src/sage/rings/polynomial/pbori/parallel.py 59.82% <0.00%> (-1.79%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 47.50% <0.00%> (-1.55%) ⬇️
src/sage/modular/arithgroup/congroup_gamma0.py 94.41% <0.00%> (-0.56%) ⬇️
src/sage/cpython/_py2_random.py 74.79% <0.00%> (-0.42%) ⬇️
src/sage/graphs/generic_graph.py 89.14% <0.00%> (-0.40%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-0.40%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Feb 11, 2023
Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems the right thing to do.

@dimpase
Copy link
Member

dimpase commented Feb 12, 2023

OK, any chance it's getting properly fixed? (the code was written by @vbraun, as git blame says)

@dimpase
Copy link
Member

dimpase commented Feb 14, 2023

let's merge this - it will improve CI

@dimpase dimpase merged commit 11dd1bd into sagemath:develop Feb 14, 2023
@tornaria tornaria deleted the klyachko branch March 6, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants