Add Hadamard matrices up to order 1000 #35059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdjoyner
approved these changes
Feb 11, 2023
|
a fresh eye looking at docstrings might be helpful |
I should be more familiar with how github works, but I'm not. Doesn't github render the rst files? I'm just seeing diff files. They seem okay, from what I saw, but it's it's a lot of code to read. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35059 +/- ##
===========================================
+ Coverage 88.57% 88.59% +0.01%
===========================================
Files 2140 2140
Lines 397273 397510 +237
===========================================
+ Hits 351891 352168 +277
+ Misses 45382 45342 -40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
we're getting this fixed in #34984 |
Thanks! |
* Improve camera positioning for threejs * Changes to sagedoc, stopgap and superseded; one mass replacement * Another mass replacement * Another mass replacement * Another replacement * Another replacement * Remove comment numbers * Fix a couple of strays * trac ticket -> github issue * Change checksums back, fix meta-ticket * Another mass replacement * Another mass replacement * Another mass replacement * Manual fixes * Small replacement * Small replacement * Fix typo * Add github role to tox * add explicit formulas to documentation of WeierstrassIsomorphism * lift documentation from .__init__() to class and tweak * add doctest for sagemath#20847 * add .torsion_basis() method to EllipticCurve_finite_field * Revert "Remove comment numbers" This reverts commit 27cdf3e. * Revert changes to git_trac.rst * Switch :github: to :issue: * Switch from sage-prod to sage in attachment links * Change trac_number to issue_number * cross linked matrix method * Add construction of strongly regular digraph * A few manual fixes * Another automatic change * Undo a bunch of changes in the doc directory * Another fix * Try to fix sphinx problem * Move comment tag inside * allowing iterables as input * Fix code style * generalized fix * converting iterables * added is_supergreedy() function * implemented diff algo, for borderline cases * correcting function for disjoint set of points * correcting function * documentation changes * minor chagnges * fixing_failing_tests * minor documentation correction * Update linear_extensions.py * corrected TeX maths in docstrings * further fixes to supergreedy docstring * Added Reference * adding reference * minor updates * correcting documentation errors * correct a wrong change to :trac: * remove spurrious blank line * another spurrious line removed * compute matrix kernels modulo composites * fix doctests * docstring style tweak * adding doctests * correct the import location (duh...) * adding colored permutation doctests * doctests fixes * replaced "Combining Caron"+c with one unicode character * Updated SageMath version to 10.0.beta1 --------- Co-authored-by: Kwankyu Lee <ekwankyu@gmail.com> Co-authored-by: David Roe <roed.math@gmail.com> Co-authored-by: Lorenz Panny <lorenz@yx7.cc> Co-authored-by: Marc Mezzarobba <marc@mezzarobba.net> Co-authored-by: Tobias Diez <code@tobiasdiez.com> Co-authored-by: Sandstorm831 <gargrohan138@gmail.com> Co-authored-by: Rohan Garg <76916164+Sandstorm831@users.noreply.github.com> Co-authored-by: Dima Pasechnik <dima@pasechnik.info> Co-authored-by: Release Manager <release@sagemath.org>
4 tasks
|
Documentation preview for this PR is ready! π |
vbraun
pushed a commit
that referenced
this pull request
Apr 1, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### π Description This PR adds constructions for all known skew Hadamard matrices of order up to 1000. The following changes have been made: - more skew Supplementary difference sets have been added - The functions for supplementary difference sets in `difference_family.py` have been changed so that now they also return the group to which the sets belong. This makes the functions consistent with the others contained in this file, and makes them more efficient. - Added construction of skew Hadamard matrices from complementary difference sets (and construction for complementary difference sets). - Added construction of skew Hadamard matrices from amicable Hadamard matrices and Orthogonal Designs (and construction for some amicable Hadamard matrices). Note that only commits from c0eb0c1 are new, the older ones where created in #35059. <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> ### π Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [ ] I have linked an issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### β Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> #35059: this PR adds (non skew) Hadamard matrices of order <= 1000 URL: #35211 Reported by: MatteoCati Reviewer(s): Dima Pasechnik, MatteoCati, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
Added new construction for (non skew) Hadamard matrices of order up to 1000. The only orders <1000 for which no construction is known are 668, 716, 892.
In particular, the following has been changed:
Note that only commits starting from 15e1b50 are new, the previous ones where created in #34985.
π Checklist
β Dependencies