Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use enum for face iterator status #35087

Merged

Conversation

kliem
Copy link
Contributor

@kliem kliem commented Feb 12, 2023

πŸ“š Description

Related to the feature request in #34773, I'm trying to make my own code a bit more readable.

Here we replace the int representing the status of the face of the iterator by an enumerator. This allows understanding this variable without having to look up the meaning.

πŸ“ Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Base: 88.59% // Head: 88.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (6fc734e) compared to base (05329f6).
Patch has no changes to coverable lines.

❗ Current head 6fc734e differs from pull request most recent head 038fbda. Consider uploading reports for the commit 038fbda to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35087      +/-   ##
===========================================
- Coverage    88.59%   88.59%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       396998   396961      -37     
===========================================
- Hits        351740   351670      -70     
- Misses       45258    45291      +33     
Impacted Files Coverage Ξ”
...e/combinat/cluster_algebra_quiver/mutation_type.py 52.25% <0.00%> (-2.38%) ⬇️
src/sage/groups/additive_abelian/qmodnz.py 91.48% <0.00%> (-2.13%) ⬇️
src/sage/modular/local_comp/liftings.py 98.33% <0.00%> (-1.67%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-0.79%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
src/sage/schemes/elliptic_curves/hom.py 83.33% <0.00%> (-0.62%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
src/sage/quadratic_forms/binary_qf.py 92.78% <0.00%> (-0.50%) ⬇️
src/sage/combinat/constellation.py 91.18% <0.00%> (-0.41%) ⬇️
src/sage/modular/overconvergent/hecke_series.py 98.76% <0.00%> (-0.31%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kliem
Copy link
Contributor Author

kliem commented Feb 13, 2023

Thank you.

@github-actions
Copy link

Documentation preview for this PR is ready! πŸŽ‰
Built with commit: 038fbda

@vbraun vbraun merged commit 44aef4a into sagemath:develop Mar 19, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants