-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scip_backend: Remove use of deprecated sage.ext.memory_allocator #35101
scip_backend: Remove use of deprecated sage.ext.memory_allocator #35101
Conversation
β¦cated_sage_ext_memory_allocator SageMath version 10.0.beta0, Release Date: 2023-02-12
β¦cated_sage_ext_memory_allocator
Documentation preview for this PR is ready! π |
Codecov ReportBase: 88.58% // Head: 88.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35101 +/- ##
========================================
Coverage 88.58% 88.58%
========================================
Files 2140 2140
Lines 396961 396961
========================================
+ Hits 351655 351666 +11
+ Misses 45306 45295 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
Do you know of plans to remove unused imports with a linter? |
Thanks for the review! I think pycodestyle can catch unused imports, but probably not for Cython modules, and also it's not part of our minimal configuration of pycodestyle, I think. Also pyright probably includes warnings about that within its huge output |
π Description
Fixes #34941
π Checklist
β Dependencies