Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scip_backend: Remove use of deprecated sage.ext.memory_allocator #35101

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Feb 13, 2023

πŸ“š Description

Fixes #34941

πŸ“ Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@mkoeppe mkoeppe requested a review from kliem February 13, 2023 19:09
@github-actions
Copy link

Documentation preview for this PR is ready! πŸŽ‰
Built with commit: e736b5d

@codecov-commenter
Copy link

Codecov Report

Base: 88.58% // Head: 88.58% // Increases project coverage by +0.00% πŸŽ‰

Coverage data is based on head (e736b5d) compared to base (293dd72).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35101   +/-   ##
========================================
  Coverage    88.58%   88.58%           
========================================
  Files         2140     2140           
  Lines       396961   396961           
========================================
+ Hits        351655   351666   +11     
+ Misses       45306    45295   -11     
Impacted Files Coverage Ξ”
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/modular/modform/numerical.py 94.19% <0.00%> (-0.65%) ⬇️
src/sage/rings/polynomial/ore_polynomial_ring.py 89.40% <0.00%> (-0.43%) ⬇️
src/sage/schemes/elliptic_curves/cardinality.py 87.00% <0.00%> (-0.40%) ⬇️
src/sage/modular/arithgroup/arithgroup_perm.py 92.57% <0.00%> (-0.38%) ⬇️
src/sage/graphs/graph_plot.py 84.33% <0.00%> (-0.29%) ⬇️
src/sage/quadratic_forms/ternary_qf.py 67.12% <0.00%> (-0.20%) ⬇️
src/sage/rings/function_field/ideal.py 89.47% <0.00%> (-0.17%) ⬇️
src/sage/combinat/posets/poset_examples.py 88.53% <0.00%> (-0.15%) ⬇️
src/sage/graphs/digraph.py 92.58% <0.00%> (-0.13%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@kliem
Copy link
Contributor

kliem commented Feb 14, 2023

Do you know of plans to remove unused imports with a linter?

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 14, 2023

Thanks for the review!

I think pycodestyle can catch unused imports, but probably not for Cython modules, and also it's not part of our minimal configuration of pycodestyle, I think.

Also pyright probably includes warnings about that within its huge output

@vbraun vbraun merged commit a07e273 into sagemath:develop Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scip_backend: Remove use of deprecated sage.ext.memory_allocator
4 participants