-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional package cvxpy, update cylp, add CVXPY MIP backend #35120
Add optional package cvxpy, update cylp, add CVXPY MIP backend #35120
Conversation
β¦LinearProgram(solver="CVXPY/SciPy/HiGHS") etc.
β¦efault solver if available
β¦thon, osqp, scs, ecos
β¦hen no name is given
β¦ariable bounds to float
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #35120 +/- ##
===========================================
- Coverage 88.62% 88.61% -0.01%
===========================================
Files 2148 2148
Lines 398855 398855
===========================================
- Hits 353480 353452 -28
- Misses 45375 45403 +28 see 25 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report in Codecov by Sentry. |
are there any tests to see this working? |
In addition to the tests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you! |
Merge conflict |
β¦onal_package_cvxpy
trivial merge, back to positive review |
I though there is now a CI test that builds the PDF docs? Because this ticket doesn't build because of an invisible U+200B:
|
That PR #35169 is still waiting for review |
here is the problem: --- a/build/pkgs/cylp/SPKG.rst
+++ b/build/pkgs/cylp/SPKG.rst
@@ -9,7 +9,11 @@ A Python interface for CLP, CBC, and CGL
License
-------
-Eclipse Public License
+Eclipse Public License (EPL) version 2 (without a Secondary Licenses Notice).
+
+Note: This license is incompatible with the GPL according to
+<200b>https://www.gnu.org/licenses/license-list.html#EPL2;
+see also the discussion in :trac:`26511`.
|
Documentation preview for this PR is ready! π |
π Description
Fixes #34251
π Checklist
β Dependencies