-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix French notation for Tableau plots #35128
Conversation
don't you want to add tests to show this output in the different conventions? maybe using |
Good idea =D I've included a couple of plots to show the difference. I think there's no way to test them though right? |
looking at the results (actually, right here, after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have these examples slightly less non-generic? (It would also take away the fear that in general it might not work)
Codecov ReportBase: 88.59% // Head: 88.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35128 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.01%
===========================================
Files 2140 2140
Lines 396961 396964 +3
===========================================
- Hits 351677 351655 -22
- Misses 45284 45309 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Documentation preview for this PR is ready! 🎉 |
📚 Description
The change fixes a bug in which the plot of a Tableau was not properly showing French notation when trying to display the plot.
The fix in place allows the plot of a Tableau to accurately show the tableau in both French and English notation, as requested by the user.
This resolves open issue: #33998 which was imported from Trac
📝 Checklist
(As the issue is with plot and is a bug; no tests can cover the changes and documentation does not need changing)
⌛ Dependencies