Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the PR template #35141

Merged
merged 5 commits into from Mar 26, 2023
Merged

Revise the PR template #35141

merged 5 commits into from Mar 26, 2023

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Feb 15, 2023

📚 Description

Made small edits to the PR template, making it concise and tidy overall.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tobiasdiez tobiasdiez changed the title Make the PR template tidy Revise the PR template Feb 15, 2023
@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 15, 2023

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Base: 88.59% // Head: 88.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (726a53d) compared to base (05329f6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35141      +/-   ##
===========================================
- Coverage    88.59%   88.59%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       396998   396998              
===========================================
- Hits        351740   351706      -34     
- Misses       45258    45292      +34     
Impacted Files Coverage Δ
src/sage/categories/super_modules_with_basis.py 96.29% <0.00%> (-3.71%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 52.25% <0.00%> (-2.38%) ⬇️
src/sage/modular/local_comp/liftings.py 98.33% <0.00%> (-1.67%) ⬇️
...rc/sage/categories/super_lie_conformal_algebras.py 95.00% <0.00%> (-1.67%) ⬇️
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-0.79%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
src/sage/schemes/elliptic_curves/hom.py 83.33% <0.00%> (-0.62%) ⬇️
src/sage/quadratic_forms/binary_qf.py 92.78% <0.00%> (-0.50%) ⬇️
src/sage/graphs/tutte_polynomial.py 93.57% <0.00%> (-0.46%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kwankyu kwankyu mentioned this pull request Feb 17, 2023
@kwankyu kwankyu mentioned this pull request Feb 22, 2023
1 task
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: eea03f2

@vbraun vbraun merged commit a40b488 into sagemath:develop Mar 26, 2023
@kwankyu kwankyu deleted the fix/pr-template branch March 26, 2023 15:29
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants