Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equal hashes for non-isomorphic bipartite graphs with edge labels #35146

Merged
merged 14 commits into from
Mar 26, 2023

Conversation

dcoudert
Copy link
Contributor

@dcoudert dcoudert commented Feb 15, 2023

Fixes #33255

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Base: 88.59% // Head: 88.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (d3618f1) compared to base (fbb4127).
Patch coverage: 93.10% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35146      +/-   ##
===========================================
- Coverage    88.59%   88.58%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       396961   396987      +26     
===========================================
+ Hits        351677   351683       +6     
- Misses       45284    45304      +20     
Impacted Files Coverage Δ
src/sage/graphs/bipartite_graph.py 90.04% <87.50%> (-0.09%) ⬇️
src/sage/graphs/digraph.py 92.73% <100.00%> (+0.02%) ⬆️
src/sage/graphs/generic_graph.py 89.13% <100.00%> (+0.01%) ⬆️
src/sage/graphs/graph.py 93.79% <100.00%> (+<0.01%) ⬆️
...e/combinat/cluster_algebra_quiver/mutation_type.py 52.25% <0.00%> (-0.72%) ⬇️
src/sage/rings/polynomial/ore_polynomial_ring.py 89.40% <0.00%> (-0.43%) ⬇️
src/sage/cpython/_py2_random.py 76.03% <0.00%> (-0.42%) ⬇️
src/sage/combinat/constellation.py 91.18% <0.00%> (-0.41%) ⬇️
src/sage/quadratic_forms/ternary_qf.py 66.73% <0.00%> (-0.39%) ⬇️
src/sage/modular/arithgroup/arithgroup_perm.py 92.57% <0.00%> (-0.38%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: d3618f1

@dcoudert
Copy link
Contributor Author

Ready for review.

@mkoeppe
Copy link
Member

mkoeppe commented Feb 16, 2023

I've changed the description to use the magic word "Fixes ", which makes GitHub mark the PR as one that should automatically close the linked issue when merged.

@dcoudert
Copy link
Contributor Author

Thank you. I'm learning every day new functionalities of GitHub.

@roed314 roed314 self-requested a review March 4, 2023 08:00
Copy link
Contributor

@roed314 roed314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun vbraun merged commit e97e587 into sagemath:develop Mar 26, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Equal hashes for non-isomorphic bipartite graphs with edge labels
7 participants