Fix bug in is_eulerian #35170
Merged
Fix bug in is_eulerian #35170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR is ready! 🎉 |
|
I don't think that the |
|
Thanks for the review. |
4 tasks
vbraun
pushed a commit
that referenced
this pull request
Jun 3, 2023
… vertices
### 📚 Description
As illustrated by the following code, the method `adjacency_matrix` of
the GenericGraph class failed when vertices where not sortable.
```python
G = Graph()
G.add_vertices ([14, 'test'])
G.adjacency_matrix()
```
I fixed the problem by using `sort=False` instead of `sort=True` in the
line that get the list of vertices.
I did not open an issue for this bug, but it is similar to #35168 (fixed
by PR #35170)
**NOTE**
I started to write a test to cover the changes but all others test are
broken by this small commit. Indeed the adjacency matrix obtained with
the new code can have a different row/column order. I am not sure what
is the correct way to handle this situation
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
URL: #35245
Reported by: cyrilbouvier
Reviewer(s): cyrilbouvier, David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Fixes #35168.
We set parameter
sorttoFalsewhen callingconnected_components. This fixes the bug as we avoid sorting vertices with different types.📝 Checklist
⌛ Dependencies
None