Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pep E303 in all folders starting with [defghi] #35244

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

This fixes all pycodestyle warning about E303 in all folders whose first letter is among defghi.

E303 too many blank lines

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 874da86

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (5330147) 88.61% compared to head (874da86) 88.58%.

❗ Current head 874da86 differs from pull request most recent head 2b32a1b. Consider uploading reports for the commit 2b32a1b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35244      +/-   ##
===========================================
- Coverage    88.61%   88.58%   -0.03%     
===========================================
  Files         2148     2140       -8     
  Lines       398855   397415    -1440     
===========================================
- Hits        353438   352045    -1393     
+ Misses       45417    45370      -47     
Impacted Files Coverage Δ
src/sage/data_structures/stream.py 97.47% <ø> (ø)
src/sage/databases/findstat.py 27.47% <ø> (+0.02%) ⬆️
src/sage/databases/knotinfo_db.py 45.61% <ø> (ø)
src/sage/doctest/reporting.py 74.45% <ø> (ø)
src/sage/features/__init__.py 95.18% <ø> (ø)
src/sage/finance/markov_multifractal.py 98.00% <ø> (ø)
src/sage/functions/exp_integral.py 90.24% <ø> (ø)
src/sage/games/hexad.py 86.97% <ø> (ø)
src/sage/games/sudoku.py 100.00% <ø> (ø)
src/sage/geometry/cone.py 93.60% <ø> (ø)
... and 38 more

... and 154 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vbraun
Copy link
Member

vbraun commented Mar 26, 2023

Merge conflict

@fchapoton
Copy link
Contributor Author

back to positive after trivial merge

@vbraun vbraun merged commit 211c2a1 into sagemath:develop Apr 1, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 1, 2023
@fchapoton fchapoton deleted the fix_E303_in_folders_defghi branch July 16, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants