Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch some more precise exceptions in combinat/ #35249

Merged
merged 1 commit into from
Apr 1, 2023
Merged

catch some more precise exceptions in combinat/ #35249

merged 1 commit into from
Apr 1, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

Using except Exception is not a good idea in general. Let us try to catch more precise exceptions.

Here done (partially) inside combinat/

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 1fb64ef

dcoudert
dcoudert approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 6332899 into sagemath:develop Apr 1, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 1, 2023
@fchapoton fchapoton deleted the catch_more_precise_combinat branch July 16, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: combinatorics
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe