support calling PARI's qfbcornacchia() from BinaryQF #35262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35262 +/- ##
===========================================
- Coverage 88.62% 88.61% -0.02%
===========================================
Files 2148 2148
Lines 398855 398665 -190
===========================================
- Hits 353480 353263 -217
- Misses 45375 45402 +27
... and 118 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
yyyyx4
force-pushed
the
public/support_pari_qfbcornacchia
branch
from
6a8b260
to
b7233c8
Compare
tscrim
requested changes
Mar 14, 2023
2 tasks
SageMath version 10.0.beta5, Release Date: 2023-03-19
|
Documentation preview for this PR is ready! 🎉 |
|
See |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of PARI have a
qfbcornacchia()function which can replace special cases ofqfbsolve()while being much faster. In this patch we add a path toqfbcornacchia()in theBinaryQF.solve_integer()method; it can be selected using an optionalalgorithm=argument. See the added doctest for an example of the speedup.Also fixes #35292.