Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pplpy to 0.8.7 - to make gcc 12.2.1 happy #35290

Merged
merged 1 commit into from
Apr 1, 2023
Merged

update pplpy to 0.8.7 - to make gcc 12.2.1 happy #35290

merged 1 commit into from
Apr 1, 2023

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Mar 15, 2023

📚 Description update pplpy to 0.8.7

with 0.8.6, gcc 12.2.1 complains, see #35285 (comment)

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.

@dimpase dimpase marked this pull request as draft March 15, 2023 13:32
@dimpase
Copy link
Member Author

dimpase commented Mar 15, 2023

oops, by mistake I pushed here rather than to my fork. I'll remove the branch once this is merged, sorry for the mess.

@dimpase dimpase marked this pull request as ready for review March 15, 2023 13:50
@dimpase dimpase requested a review from videlec March 15, 2023 13:55
@dimpase
Copy link
Member Author

dimpase commented Mar 15, 2023

for some reason, the pypi 0.8.7 never made it to Sage. But it's apparently needed for gcc 12.2.1

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: a11c23e

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (f449b14) 88.62% compared to head (a11c23e) 88.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35290      +/-   ##
===========================================
- Coverage    88.62%   88.60%   -0.02%     
===========================================
  Files         2148     2148              
  Lines       398653   398653              
===========================================
- Hits        353308   353246      -62     
- Misses       45345    45407      +62     

see 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dimpase
Copy link
Member Author

dimpase commented Mar 15, 2023

the test failure is unrelated, and reported here #35292 (a lucky random seed triggered a bug elsewhere)

@vbraun vbraun merged commit f6f4bdd into develop Apr 1, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 1, 2023
vbraun pushed a commit that referenced this pull request Oct 8, 2023
    
### 📚 system pkgs info and GH actions for alpine linux

Will fix #33083. This is the rebase of the branch of the latter on top
of 10.0.beta4, reduced to the scripts and package lists.

Workarounds for musl libc from #33083 will be revisited in a follow up.

### 📝 Checklist


- [X] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [X] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### Dependencies

- #35290 - pplpy 0.8.7
- #35094 - saner libsingular linking
    
URL: #35285
Reported by: Dima Pasechnik
Reviewer(s): Dima Pasechnik, Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants