Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix radius and diameter for digraphs with non-comparable vertices #35310

Merged

Conversation

dcoudert
Copy link
Contributor

Fixes #35300.

πŸ“š Description

We specify an ordering of the vertices in the call to eccentricity. This way we fix both radius and diameter.

πŸ“ Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! πŸŽ‰
Built with commit: bab1966

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02 ⚠️

Comparison is base (c00e6c2) 88.62% compared to head (bab1966) 88.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35310      +/-   ##
===========================================
- Coverage    88.62%   88.60%   -0.02%     
===========================================
  Files         2148     2148              
  Lines       398855   398855              
===========================================
- Hits        353480   353414      -66     
- Misses       45375    45441      +66     
Impacted Files Coverage Ξ”
src/sage/graphs/digraph.py 92.58% <66.66%> (-0.13%) ⬇️

... and 28 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@fchapoton
Copy link
Contributor

ok

@vbraun vbraun merged commit ad0ea73 into sagemath:develop Apr 1, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiGraph.radius fails for directed graphs with non-comparable vertices
5 participants