Make data_structures/bitset_base.pxd
use explicit integer division
#35313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
I had an issue when trying to compile a Cython project using Cython's
language_level
compiler directive (see Cythondocs as well as the issue linked below for more info) set to
3
, and was getting issues because Python2's/
operator yielded floor division in this file (float division wouldn't make sense in this context), whereas in Python3 it is always float division.This commit converts the implicit floor divisions to explicit ones, so that bitsets are able to be used for Cython projects compiled with the
language_level=3
compiler directive.This should not cause any backwards compatibility issues either, as
//
explicitly designates floor division in both versions of Python.Closes #34768
π Checklist
β Dependencies
N/A