Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly list develop packages in conda dev environment #35349

Merged
merged 1 commit into from Apr 6, 2023

Conversation

tobiasdiez
Copy link
Contributor

πŸ“š Description

Some develop packages (such as pytest) were missing from the environment-dev.yml file.

πŸ“ Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! πŸŽ‰
Built with commit: e2bd466

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (c00e6c2) 88.62% compared to head (e2bd466) 88.62%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35349   +/-   ##
========================================
  Coverage    88.62%   88.62%           
========================================
  Files         2148     2148           
  Lines       398855   398855           
========================================
  Hits        353480   353480           
  Misses       45375    45375           

see 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@tobiasdiez
Copy link
Contributor Author

Thanks for the review!

@vbraun vbraun merged commit 180eeb3 into sagemath:develop Apr 6, 2023
5 checks passed
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants