Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordMorphism: remove keyword deprecated in #26307 #35421

Merged
merged 1 commit into from
Apr 6, 2023
Merged

WordMorphism: remove keyword deprecated in #26307 #35421

merged 1 commit into from
Apr 6, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

Remove the deprecated datatype argument in word morphisms introduced in #26307

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe changed the title remove deprecation from 26307 WordMorphism: remove keyword deprecated in #26307 Apr 2, 2023
@fchapoton fchapoton requested a review from seblabbe April 3, 2023 07:39
seblabbe
seblabbe approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@seblabbe seblabbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I pulled the branch and all tests passed in the combinat/words folder

@fchapoton
Copy link
Contributor Author

merci Sébastien. En fait, les tests ont aussi été vérifiés par le "check" Build and Test.
Alors il faut ajouter le label "positive review" steuplait (et enlever needs review)

tscrim
tscrim approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seblabbe
Copy link
Contributor

seblabbe commented Apr 4, 2023

Ok, I see, clicking "Approved this changes" was not sufficient, I also need to update the label. I will know for next time.

@vbraun vbraun merged commit 17d2e17 into sagemath:develop Apr 6, 2023
3 of 5 checks passed
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 7, 2023
@fchapoton fchapoton deleted the remove_deprecation_26307 branch July 16, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

@seblabbe seblabbe seblabbe approved these changes

Assignees
No one assigned
Labels
c: combinatorics t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fchapoton @seblabbe @tscrim @vbraun @mkoeppe