Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep8 and code details in weyl_characters.py #35459

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

fchapoton
Copy link
Contributor

πŸ“š Description

Partial pep8 cleanup of the wile weyl_characters.py

also simplifying some dictionary constructions

and renaming adams_operation to adams_operator

πŸ“ Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Documentation preview for this PR is ready! πŸŽ‰
Built with commit: e33815f

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

At first I was surprised by the name change of method _adams_operation_helper, and then I saw the line adams_operation = adams_operator.

@vbraun vbraun merged commit a6e2c32 into sagemath:develop Apr 13, 2023
8 of 9 checks passed
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants