Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Feichtner-Yuzvinsky rings for lattices #35472

Merged

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Apr 10, 2023

πŸ“š Description

We provide an implementation of the Feichtner-Yuzvinsky ring of a lattice $L$ and a subset $G \subseteq L$. Our implementation is a slight generalization of the original definition to let $G$ be arbitrary. This is a commutative ring associated to a lattice as the quotient of $R[h_g | g \in G]$ by all $h_a$ for $a \in G$ an atom of $L$ and

$$ \prod_{a \in A} h_g - h_a, $$

where $A$ is an antichain of $G$ such that $g := \bigvee A \in G$.

πŸ“ Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@tscrim tscrim requested a review from fchapoton April 10, 2023 03:53
@tscrim tscrim force-pushed the combinat/posets/feichtner_yuzvinsky_rings branch from 93b05c6 to 625f262 Compare April 10, 2023 03:53
add missing \
@github-actions
Copy link

Documentation preview for this PR is ready! πŸŽ‰
Built with commit: ca3eaf6

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 17, 2023

@fchapoton Thank you for pushing that fix (I was away from a development computer this weekend). Your change LGTM. If everything else is fine, then please approve and set to a positive review.

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 17, 2023

Thank you.

@vbraun vbraun merged commit eafd521 into sagemath:develop Apr 23, 2023
10 checks passed
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 23, 2023
@tscrim tscrim deleted the combinat/posets/feichtner_yuzvinsky_rings branch April 28, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants