Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation and random doctest failure for Cornacchia algorithm #35486

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Apr 12, 2023

This patch should fix the random doctest failure pointed out in #35292 (comment), following an upstream documentation update that was applied to resolve PARI bug #2471.

Copy link

Documentation preview for this PR (built with commit e53ce0d; changes) is ready! 🎉

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks reasonable

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 4, 2023
…rnacchia algorithm

    
This patch should fix the random doctest failure pointed out in
sagemath#35292 (comment),
following an upstream documentation update that was applied to resolve
[PARI bug sagemath#2471](https://pari.math.u-bordeaux.fr/cgi-
bin/bugreport.cgi?bug=2471).
    
URL: sagemath#35486
Reported by: Lorenz Panny
Reviewer(s): Frédéric Chapoton, Lorenz Panny, Rémy Oudompheng
@vbraun vbraun merged commit 8217447 into sagemath:develop Dec 6, 2023
15 of 20 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 6, 2023
@yyyyx4 yyyyx4 deleted the public/random_failure_35292 branch January 19, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants