Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.rings.factorint: Modularization fixes #35502

Merged
merged 6 commits into from
May 22, 2023
Merged

sage.rings.factorint: Modularization fixes #35502

merged 6 commits into from
May 22, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Apr 14, 2023

📚 Description

Spliiting sage.rings.factorint into separate modules, per library used.

Part of:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Apr 14, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this pull request Apr 14, 2023
@mkoeppe
src/sage/rings/factorint.pyx: Revert; this file is handled in sagemat…
bf431b4 
…h#35502
@mkoeppe mkoeppe requested a review from videlec April 14, 2023 23:56
@Drewshotwell
Copy link

This is looking good from my testing. The only thing I noticed is that in the Examples section it's still sage: from sage.rings.factorint import factor_using_flint when it should be sage: from sage.rings.factorint_flint import factor_using_flint

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 23, 2023

Thanks for catching this; fixed now

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 24, 2023

Please add boilerplate head stuffs, especially copyright notice.

@mkoeppe
Merge tag '10.0.rc0' into factorint_flint_separate
f82cbd1 
SageMath version 10.0.rc0, Release Date: 2023-04-23
@mkoeppe
src/sage/rings/factorint*: Update/add copyright following 'git blame …
e8051b8 
…-M -C src/sage/rings/factorint.pyx -w --date=format:%Y 10.0.rc0 | sort -k2'
@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 24, 2023

Thanks, done.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: e8051b8

kwankyu
kwankyu approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 24, 2023

Thank you!

@vbraun vbraun merged commit 07bd424 into sagemath:develop May 22, 2023
7 of 9 checks passed
@mkoeppe mkoeppe added this to the sage-10.1 milestone May 22, 2023
@mkoeppe mkoeppe mentioned this pull request Jun 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@videlec videlec Awaiting requested review from videlec

Assignees

@mkoeppe mkoeppe

Labels
t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkoeppe @Drewshotwell @kwankyu @vbraun