Fix Graph.add_clique() for one vertex #35511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change:
sage: g = Graph()
sage: g.add_clique([1,2])
sage: g.add_clique([3])
sage: g.vertices(sort=True)
[1, 2]
After the change:
sage: g = Graph()
sage: g.add_clique([1,2])
sage: g.add_clique([3])
sage: g.vertices(sort=True)
[1, 2, 3]
|
Documentation preview for this PR is ready! 馃帀 |
dcoudert
approved these changes
Apr 15, 2023
3 tasks
vbraun
pushed a commit
that referenced
this pull request
Apr 23, 2023
Simplify the code; also, the previous code has to iterate over variables of the sequence twice (this is really bad before #35510). This affects mainly the method `connected_components()`. EDIT: Moreover, now we add a clique between the variables of each polynomial, so it agrees with the description (the code before used to add just a spanning tree of the clique -- a star). This makes this method a little bit slower for the purposes of `connected_components()` (for which adding a star is equivalent). However, #35518 will rewrite `connected_components()` without using `connection_graph()` so this is not really a problem. ### 馃摑 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] New tests added to check that a clique is added for the variables in each polynomial. ### Dependencies - #35511 URL: #35512 Reported by: Gonzalo Tornar铆a Reviewer(s): David Coudert, Gonzalo Tornar铆a, Vincent Delecroix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change:
After the change:
馃摑 Checklist