Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force ecl lisp with maxima -l ecl on command line. #35514

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

tornaria
Copy link
Contributor

Instead, use maxima which should run maxima under the default lisp. This is consistet with what happens with sage.interfaces.maxima.

Note that maxima_lib needs maxima built with ecl, but the pexpect interface to maxima works with any lisp and there are faster builds of maxima (e.g. the one compiled with sbcl).

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Instead, use `maxima` which should run maxima under the default lisp.
This is consistet with what happens with `sage.interfaces.maxima`.

Note that `maxima_lib` needs maxima built with ecl, but the pexpect
interface to maxima works with any lisp and there are faster builds of
maxima (e.g. the one compiled with sbcl).
@tornaria tornaria requested a review from kiwifb April 15, 2023 03:45
@kiwifb
Copy link
Member

kiwifb commented Apr 15, 2023

I'll admit, that was my doing some time ago.

@kiwifb
Copy link
Member

kiwifb commented Apr 15, 2023

Is this the only place? I thought I had put it somewhere else.

@tornaria
Copy link
Contributor Author

Is this the only place? I thought I had put it somewhere else.

I think this is the only place left. Please check that it still works ok for you after this change.

@kiwifb
Copy link
Member

kiwifb commented Apr 15, 2023

It will work. The only thing is that if you have maxima compiled with more than one lisp, the ecl backend is unlikely to get chosen as most of the others are before it in the picking order. Occasionally, you may get a different result. But this is only concerning the pexpect interface to maxima. maximalib will still use ecl. I will check env.py and sage_conf which are two places where I could have put stuff.

@kiwifb
Copy link
Member

kiwifb commented Apr 15, 2023

I thought I had put stuff there as well https://github.com/sagemath/sage/blob/develop/pkgs/sage-conf/_sage_conf/_conf.py.in#L12 but if I have, it has been removed. Removing -l ecl here makes things coherent.

Waiting for the last checks to run before giving you my tick.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: cd011a1

Copy link
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's freely use any maxima.

@vbraun vbraun merged commit 803c7aa into sagemath:develop Apr 23, 2023
8 of 9 checks passed
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants