Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in integer valued polys #35515

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Bug in integer valued polys #35515

merged 1 commit into from
Apr 23, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

This fixes the from _polynomialinput method for integer-valued polynomials to accept polynomial with any variable name.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 3645576

@fchapoton fchapoton requested a review from tscrim April 17, 2023 06:34
tscrim
tscrim approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton
Copy link
Contributor Author

arigato

@vbraun vbraun merged commit a38a25a into sagemath:develop Apr 23, 2023
8 of 9 checks passed
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 23, 2023
@fchapoton fchapoton deleted the bug-in-integer-valued-polys branch July 16, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: commutative algebra
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @tscrim @vbraun @mkoeppe