Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept system openblas 0.3.23 and newer (needed for archlinux) #35524

Merged
merged 2 commits into from
May 7, 2023

Conversation

remyoudompheng
Copy link
Contributor

πŸ“š Description

The configure script was updated to reject openblas 0.3.22 but the test introduced in #35377 is too restrictive and excludes openblas 0.3.23.
This patch addresses the issue for the non pkg-config case (currently on Archlinux, openblas.pc has no version number and pkg-config is not used in the configure process).

πŸ“ Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@remyoudompheng
Copy link
Contributor Author

I'm not sure how to handle the pkg-config case (the syntax is not very flexible).

@mkoeppe
Copy link
Member

mkoeppe commented Apr 23, 2023

Marking this as critical because on archlinux, we neither accept the system openblas nor are able to build our own openblas (#34899)

@mkoeppe mkoeppe changed the title Accept system openblas 0.3.23 Accept system openblas 0.3.23 and newer Apr 30, 2023
@mkoeppe mkoeppe self-assigned this Apr 30, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 30, 2023
@mkoeppe mkoeppe changed the title Accept system openblas 0.3.23 and newer Accept system openblas 0.3.23 and newer (needed for archlinux) Apr 30, 2023
@github-actions
Copy link

Documentation preview for this PR is ready! πŸŽ‰
Built with commit: 3d0467f

@mkoeppe
Copy link
Member

mkoeppe commented Apr 30, 2023

Thanks!

@prirai
Copy link
Contributor

prirai commented May 1, 2023

I'm on Archlinux and facing the same issue as described. I previously built sage successfully from source when the OpenBLAS version was 0.3.21 and the OpenBLAS was built from https://aur.archlinux.org/packages/openblas-lapack .
Now when I do the same now, the OpenBLAS package isn't detected and the built of OpenBLAS (0.2.23) fails as mentioned in the above comments. Looking at the logs doesn't provide anything helpful at all. Also, the AUR package doesn't build currently on my system as I've mentioned here - aur/openblas-lapack#comment-912197 by prs.

What can be a workaround at the present?

@dimpase
Copy link
Member

dimpase commented May 1, 2023

Now when I do the same now, the OpenBLAS package isn't detected

you need to pull the branch of this PR, have you done it?

@prirai
Copy link
Contributor

prirai commented May 1, 2023

you need to pull the branch of this PR, have you done it?

After many trials, I went with the official repository packages for openblas and lapack and was able to successfully build sage after cleaning the previous build files and everything seems to be working fine now. Should I also try using this method? Note that I'm unable to build the 0.3.23 package for OpenBLAS as mentioned above so this was the only resort and openblas didn't install through the sage build. Am I missing something?

(This was started before your comment so I waited for this build).

@dimpase
Copy link
Member

dimpase commented May 1, 2023

official repository packages for openblas and lapack

official - as your OS (Archlinux) official, or upstream (OpenBLAS) official?

@prirai
Copy link
Contributor

prirai commented May 1, 2023

official - as your OS (Archlinux) official, or upstream (OpenBLAS) official?

I'm referring to the Archlinux package repository here. The upstream project only provides official binary packages for Windows.

@dimpase
Copy link
Member

dimpase commented May 1, 2023

OK then - this PR is exactly for this purpose.

@vbraun vbraun merged commit 686e1c6 into sagemath:develop May 7, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants