src/sage_docbuild/conf.py: Do not fail if pplpy doc is not installed #35536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
isuruf
reviewed
May 3, 2023
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
|
I don't know if this is a valid review strategy: I did |
…inventory fetch works
|
Thanks for testing! I've pushed a fix for this |
|
With the same test method, I have verified that files such as local/share/doc/sage/html/en/reference/discrete_geometry/sage/geometry/cone.html contain the correct links (e.g. C_Polyhedron) |
|
Previous discussion:
|
|
I guess we should also update |
|
A better solution may be to use the configuration "Multiple targets for the inventory" in |
|
In fact, that's what the branch in #29231 does. I'll revive it |
|
Documentation preview for this PR is ready! 🎉 |
|
This works for me. (I used a different testing strategy: temporarily changed |
jhpalmieri
approved these changes
May 4, 2023
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 25, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> Math equations should be marked in the math environment. Change the Sphinx markup in src/sage/categories/crystals.py <!-- Why is this change required? What problem does it solve? --> Fix some Sphinx markup as posted in Issue sagemath#35496 <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> Fixes sagemath#35496 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [ ] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - sagemath#35536: branch is on top of this PR to fix a build issue in conda <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35537 Reported by: xuluze Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 27, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> Math equations should be marked in the math environment. Change the Sphinx markup in src/sage/categories/crystals.py <!-- Why is this change required? What problem does it solve? --> Fix some Sphinx markup as posted in Issue sagemath#35496 <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> Fixes sagemath#35496 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [ ] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - sagemath#35536: branch is on top of this PR to fix a build issue in conda <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35537 Reported by: xuluze Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
We change the sphinx configuration so that the object inventory of pplpy is only used when it is installed.
We currently have no way to install the pplpy documentation when using the all-conda installation method (#35528).
📝 Checklist
⌛ Dependencies