-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning set partition #35543
Cleaning set partition #35543
Conversation
src/sage/combinat/set_partition.py
Outdated
for opt in kwargs: | ||
self._latex_options[opt] = kwargs[opt] | ||
for opt, value in kwargs.items(): | ||
self._latex_options[opt] = value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this not just self._latex_options.update(kwargs)
?
Branch seems to be on top of #35542? |
1f0f95b
to
71e509a
Compare
Documentation preview for this PR is ready! π |
@@ -3197,7 +3172,7 @@ def cardinality(self): | |||
sage: stirling_number2(5,3) | |||
25 | |||
""" | |||
return stirling_number2(len(self._set), self._k) | |||
return stirling2(len(self._set), self._k) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is that better than stirling_number2
?
In case you have time: #29996 is, for me, a serious problem. |
π Description
Various details and tweaks in the code and doc of
set_partition.py
in order to reach full pep8 and better pylint compliance
π Checklist
β Dependencies