Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.quadratic_forms: Fix use of staticmethod for Python < 3.10 #35558

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Apr 24, 2023

πŸ“š Description

Fixes #35557

πŸ“ Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! πŸŽ‰
Built with commit: dcd1f18

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well on sage with python 3.9.

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 26, 2023

Nothing related with this PR, but out of curiosity, do you use the number to search for labels like "critical / 2"?

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2023

I think I use it about half of the time. Pretty rare event to use priority labels (in particular, Volker's merging script does not pay attention to them), so it's not hardwired in my fingers yet.
Also typing "s:" to see the status labels has not become a proper habit yet. I find myself typing "need" or "revi" and then click to change labels.

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 26, 2023

Thanks for the review!

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 26, 2023

Also typing "s:" to see the status labels has not become a proper habit yet. I find myself typing "need" or "revi" and then click to change labels.

I see. I just scroll to the label in the list :-)

Thanks.

@vbraun vbraun merged commit 9185bef into sagemath:develop Apr 28, 2023
9 of 11 checks passed
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sage.quadratic_forms: Fix use of staticmethod for Python < 3.10
3 participants