Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear up left right confusion in ore_polynomial_element.pyx #35562

Merged

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Apr 25, 2023

πŸ“š Description

Fix #35531. While we are at it, I made other minor edits.

πŸ“ Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@kwankyu kwankyu changed the title Edit ore polynomials Clear up left right confusion in ore_polynomial_element.pyx Apr 25, 2023
@kwankyu kwankyu requested a review from xcaruso April 25, 2023 11:13
Copy link
Contributor

@xcaruso xcaruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a lot of misprints in this documentation. Thanks for catching all of these!

@xcaruso
Copy link
Contributor

xcaruso commented Apr 27, 2023

However, the patchbot (should we continue to use this term?) reports some failures. Should we fix them before giving a positive review?

@kwankyu
Copy link
Collaborator Author

kwankyu commented Apr 27, 2023

No. They are not related with this PR. The lint check is being dealt with in other PR, and the codecov/project is plaguing all PRs.

Thanks for review!

@vbraun
Copy link
Member

vbraun commented May 20, 2023

merge conflict

@github-actions
Copy link

Documentation preview for this PR (built with commit 2f42904) is ready! πŸŽ‰

@kwankyu
Copy link
Collaborator Author

kwankyu commented May 31, 2023

Resolved merge conflict

@vbraun vbraun merged commit 6e95ea3 into sagemath:develop Jun 3, 2023
8 of 9 checks passed
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 3, 2023
@kwankyu kwankyu deleted the i/35531/left_right_confusion_ore_polynomial branch December 13, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusions in left and right division for Ore polynomials
4 participants