Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make doc preview message from github bot one liner #35563

Merged
merged 1 commit into from
May 22, 2023

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Apr 25, 2023

πŸ“š Description

For each PR, github bot emits a comment with documentation preview message. Now it consists of two lines. This PR makes it one line, for quick eye scan from left to right once instead of twice.

Screen Shot 2023-04-25 at 2 41 40 PM

(I also tried to make the doc link open in a new tab, but it seems close to impossible.)

πŸ“ Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@kwankyu kwankyu changed the title Make doc preview message one liner Make doc preview message from github bot *one liner* Apr 25, 2023
@kwankyu kwankyu changed the title Make doc preview message from github bot *one liner* Make doc preview message from github bot **one liner** Apr 25, 2023
@kwankyu kwankyu changed the title Make doc preview message from github bot **one liner** Make doc preview message from github bot ~one liner~ Apr 25, 2023
@kwankyu kwankyu changed the title Make doc preview message from github bot ~one liner~ Make doc preview message from github bot one liner Apr 25, 2023
@github-actions
Copy link

Documentation preview for this PR is ready! πŸŽ‰
Built with commit: d90d147

Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is an improvement.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Apr 26, 2023

Thanks for agreeing.

@vbraun vbraun merged commit 91be339 into sagemath:develop May 22, 2023
8 of 10 checks passed
@mkoeppe mkoeppe added this to the sage-10.1 milestone May 22, 2023
@kwankyu kwankyu deleted the make_doc_preview_message_one_liner branch December 13, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants