Remove some circular imports in sage.rings, sage.symbolic#35594
Merged
vbraun merged 16 commits intosagemath:developfrom May 7, 2023
Merged
Remove some circular imports in sage.rings, sage.symbolic#35594vbraun merged 16 commits intosagemath:developfrom
sage.rings, sage.symbolic#35594vbraun merged 16 commits intosagemath:developfrom
Conversation
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to multiply two integers" --> ### 📚 Description Fixing the linter workflow <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
Member
|
pycodestyle linter fails... |
Contributor
Author
|
That is fixed in #35552 and has nothing to do with this PR |
Member
I merged the fix into develop, so it should not any more. |
added 14 commits
May 4, 2023 17:51
dimpase
force-pushed
the
sage_symbolic_circular_import
branch
from
18398a1 to
69df1ef
Compare
dimpase
approved these changes
May 4, 2023
Contributor
Author
|
Thank you! |
|
Documentation preview for this PR is ready! 🎉 |
Member
Please don't do that unless you want to take over release management. I will force push over that, and anyone who used that will end up with unrelated merge conflicts. |
Member
|
The linter fix had been hanging for quite some time, and made CI results confusing. Besides, can you try to rebase your branch over this fix? I guess it would go without a manual intervention, and will save time for everyone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Fixes #35580.
📝 Checklist
⌛ Dependencies