register magic modes for lazy imported interfaces #35680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just made the lazy imported interfaces be registered. Didn't check if this affects starting time. |
|
Documentation preview for this PR (built with commit 83c053c) is ready! 馃帀 |
|
This looks good to me. I ran |
|
(Assuming it's ready for review.) |
miguelmarco
added
t: bug
c: user interface
p: minor / 4
c: interfaces
s: needs info
s: needs review
and removed
s: needs info
labels
|
It is. |
jhpalmieri
approved these changes
May 25, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摎 Description
Addresses #35246
The lazy imported interfaces are not registered as magic modes. This patch registers them too.
馃摑 Checklist