unify input of matrices and vectors #35685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
requested changes
May 29, 2023
There was a problem hiding this comment.
LGTM modulo a minor speed point with making two copies of the matrix (the second one being made with immutable).. You simply can change
-mu = dict((a, immutable(Matrix(M))) for a, M in mu.items())
+mu = dict((a, Matrix(M, immutable=True)) for a, M in mu.items())
dkrenn
commented
May 29, 2023
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
|
Documentation preview for this PR (built with commit a10ce8c) is ready! 馃帀 |
tscrim
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For recognizable series the input is handled differently for matrices and vectors. This easy patch unifies this.
馃摑 Checklist