-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix weak Popov form testing #35699
Fix weak Popov form testing #35699
Conversation
# leading positions should not have duplicates, which is equivalent to: | ||
# once sorted, it doesn't contain a pair of equal successive entries | ||
# (we do not sort if we want to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this line is a leftover from a previous version of the comment starting at line 1678 and should be removed? Lgtm otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely, thanks for spotting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Documentation preview for this PR (built with commit 648f21b; changes) is ready! π |
π Description
This fixes the test for weak Popov form for univariate polynomial matrices, that was wrong in some column-wise cases. This fixes issue #35698 . This adds some more comments in the code of the relevant method, to better highlight its correction.
π Checklist
β Dependencies
None.