Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some cython-linting in quadratic forms #35709

Merged
merged 2 commits into from
Jun 11, 2023
Merged

some cython-linting in quadratic forms #35709

merged 2 commits into from
Jun 11, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

fixes some cython-lint warnings in two files inside quadratic_forms (much needed, and should be continued)

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Member

mkoeppe commented Jun 2, 2023

Build failure at https://github.com/sagemath/sage/actions/runs/5158819363/jobs/9292968901?pr=35709#step:9:9929

@fchapoton fchapoton force-pushed the some-cylint-quadratic-forms branch from d5a3c7f to 8b14707 Compare June 3, 2023 15:37
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Documentation preview for this PR (built with commit fe1d6c6) is ready! 🎉

@vbraun vbraun merged commit 6a14231 into sagemath:develop Jun 11, 2023
15 of 16 checks passed
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 11, 2023
@fchapoton fchapoton deleted the some-cylint-quadratic-forms branch July 16, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fchapoton @mkoeppe @vbraun