Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/pkgs/pyflakes: Remove #35731

Merged
merged 1 commit into from
Jun 11, 2023
Merged

build/pkgs/pyflakes: Remove #35731

merged 1 commit into from
Jun 11, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Jun 5, 2023

📚 Description

We remove this package; it is unused, and anyway all linters are installed into tox environments.

Resolves #30415

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 5, 2023
@mkoeppe mkoeppe requested a review from fchapoton June 5, 2023 15:07
fchapoton
fchapoton approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Documentation preview for this PR (built with commit e4d25fb) is ready! 🎉

@tobiasdiez
Copy link
Contributor

Nice! There are a few more mentions of pyflakes (notably in the docs, but also in some code comments). Shouldn't this be removed as well? https://github.com/search?q=repo%3Asagemath%2Fsage%20pyflakes&type=code

@vbraun vbraun merged commit aba52d4 into sagemath:develop Jun 11, 2023
15 of 16 checks passed
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: packages: optional
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.

Remove pyflakes?
4 participants
@mkoeppe @tobiasdiez @fchapoton @vbraun