Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/pkgs/maxima: Fix parallel build #35737

Merged
merged 1 commit into from
Jun 11, 2023
Merged

build/pkgs/maxima: Fix parallel build #35737

merged 1 commit into from
Jun 11, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Jun 6, 2023

📚 Description

Fix a mistake in a maxima Makefile.

maxima build fails non-deterministically in parallel builds.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe requested a review from dimpase June 6, 2023 15:33
@mkoeppe mkoeppe self-assigned this Jun 6, 2023
@mkoeppe mkoeppe mentioned this pull request Jun 6, 2023
Merged
5 tasks
dimpase
dimpase approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 6, 2023

Thanks, Dima.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Documentation preview for this PR (built with commit 29fce00) is ready! 🎉

@vbraun vbraun merged commit d27b19a into sagemath:develop Jun 11, 2023
16 of 29 checks passed
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: build c: packages: standard p: blocker / 1
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkoeppe @dimpase @vbraun