Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more fixes for superfluous cython imports #35765

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

found by cython-lint ; removing a few more useless cython imports

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit 71aef78) is ready! 🎉

@dcoudert
Copy link
Contributor

By curiosity, is it ok to call sig_on() but not sig_off() in src/sage/schemes/elliptic_curves/descent_two_isogeny.pyx ?

@fchapoton
Copy link
Contributor Author

Aucune idée. Mais effectivement, on peut se poser la question. Parfois le sig_off est appelé dans une sous-routine.

@dcoudert
Copy link
Contributor

Since this sig_on has been added by Jeroen Demeyer without the sig_off, I assume it has been done on purpose.

@vbraun vbraun merged commit 48559c6 into sagemath:develop Jun 21, 2023
16 checks passed
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 21, 2023
@fchapoton fchapoton deleted the more_cython_import_fixes branch July 16, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants