sage.arith.misc: fixes error in binomial for p-adic numbers with negative valuation
#35823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 65c3e72; changes) is ready! 🎉 |
added 2 commits
October 29, 2023 15:42
tscrim
added
c: basic arithmetic
s: positive review
c: padics
and removed
c: padics
labels
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 21, 2023
…ic numbers with negative valuation
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to
multiply two integers" -->
### 📚 Description
<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
As discussed in sagemath#35811 : in case 2 of `binomial` the fix replaces
`except TypeError` by `except (TypeError, ValueError)`.
Furthermore, I added examples and tests for binomials of p-adic
numbers.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
Fixes sagemath#35811.
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#35823
Reported by: Heiko Knospe
Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 22, 2023
…ic numbers with negative valuation
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to
multiply two integers" -->
### 📚 Description
<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
As discussed in sagemath#35811 : in case 2 of `binomial` the fix replaces
`except TypeError` by `except (TypeError, ValueError)`.
Furthermore, I added examples and tests for binomials of p-adic
numbers.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
Fixes sagemath#35811.
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#35823
Reported by: Heiko Knospe
Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 23, 2023
…ic numbers with negative valuation
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to
multiply two integers" -->
### 📚 Description
<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
As discussed in sagemath#35811 : in case 2 of `binomial` the fix replaces
`except TypeError` by `except (TypeError, ValueError)`.
Furthermore, I added examples and tests for binomials of p-adic
numbers.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
Fixes sagemath#35811.
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#35823
Reported by: Heiko Knospe
Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 24, 2023
…ic numbers with negative valuation
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to
multiply two integers" -->
### 📚 Description
<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
As discussed in sagemath#35811 : in case 2 of `binomial` the fix replaces
`except TypeError` by `except (TypeError, ValueError)`.
Furthermore, I added examples and tests for binomials of p-adic
numbers.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
Fixes sagemath#35811.
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#35823
Reported by: Heiko Knospe
Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
As discussed in #35811 : in case 2 of
binomialthe fix replacesexcept TypeErrorbyexcept (TypeError, ValueError).Furthermore, I added examples and tests for binomials of p-adic numbers.
📝 Checklist
⌛ Dependencies
Fixes #35811.