Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with scipy 1.11 #35842

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Conversation

antonio-rojas
Copy link
Contributor

Fix some test failures with scipy 1.11

  • Cast to float before calling scipy.optimize.brentq, which now performs a NaN check that chokes on symbolic expressions.
  • Some Ttest_indResult are now TtestResult

There are two more failures in sage/matrix/matrix_double_dense.pyx and sage/matrix/matrix_space.py caused by an upstream issue, reported at scipy/scipy#18759

@github-actions
Copy link

Documentation preview for this PR (built with commit 064e157; changes) is ready! 🎉

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbraun vbraun merged commit 90ece16 into sagemath:develop Jul 1, 2023
16 checks passed
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jul 1, 2023
@antonio-rojas antonio-rojas deleted the scipy-1.11 branch July 2, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants