Deprecate rename_vertices parameter in disjoint_union

[OP5642]

📚 Description

The rename_vertices parameter is not mentioned anywhere within the body of the method disjoint_union. We remove the parameter.

📝 Checklist

• The title is concise, informative, and self-explanatory.
• The description explains in detail what this PR is about.
• I have linked a relevant issue or discussion.
• I have created tests covering the changes.
• I have updated the documentation accordingly.

[OP5642]

@tscrim

[tscrim]

You cannot simply remove it. You must first deprecate it. So set its default value to None, then check if it is not None, then print a deprecation message:

if rename_vertices is not None:
    from sage.misc.superseded import deprecation
    deprecation(35907, 'the "rename_vertices" argument is deprecated')

cc-ing @jhpalmieri in case you have an opinion on this argument.

[jhpalmieri]

Since the variable has no effect, I don't think it's that important to deprecate it. I don't object to deprecating it, but it's not a big deal to me.

[tscrim]

Thanks. Policy is to deprecate it just case someone has code that is using it. Anyways, I wasn't sure if you had a reason this argument should actually be implemented (and hence, would be a bug instead).

[OP5642]

Sorry for misunderstanding, @tscrim. I think it is deprecated appropriately now.

[github-actions]

Documentation preview for this PR (built with commit a6892d4; changes) is ready! 🎉

[jhpalmieri]

I think this is ready to go. Any objections to changing it from "needs work" to "positive review"? (The new deprecation doesn't have a corresponding doctest, but since the parameter wasn't used in the first place, I don't think we need to add a doctest.)

[tscrim]

@jhpalmieri Yes, I agree that it is fine without a doctest for it. We can set it to a positive review now.

[tscrim]

@OP5642 Please also change this from a draft PR to a regular PR too.