New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some pep8 cleanup in schemes/affine and schemes/curves #35916

Merged

vbraun merged 1 commit into sagemath:develop from fchapoton:pep_cleanup_schemes_1

Jul 20, 2023

Contributor

fchapoton commented Jul 8, 2023

📚 Description

This is fixing many pycodestyle warnings in the schemes folder, mostly in affine and curves subfolders

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

fchapoton added s: needs review c: algebraic geometry t: refactoring labels

mkoeppe reviewed

View reviewed changes

src/sage/schemes/affine/affine_homset.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/schemes/affine/affine_space.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/schemes/cyclic_covers/cycliccover_finite_field.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/schemes/cyclic_covers/cycliccover_finite_field.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/schemes/cyclic_covers/cycliccover_finite_field.py Outdated

@@ @@ -1065,7 +1065,7 @@ def _frobenius_matrix_p(N0): @@
                               s0 = (j * self._p) % self._r
                               for i in range(self._d - 1):
                                   m[
-                                      (s0 - 1) * (self._d - 1) : s0 * (self._d - 1),
+                                      (s0 - 1) * (self._d - 1): s0 * (self._d - 1),

Member

mkoeppe Jul 8, 2023

and again


          some pep8 cleanup in schemes/affine and schemes/curves

fdae513

fchapoton force-pushed the pep_cleanup_schemes_1 branch from 2554547 to fdae513 Compare

July 13, 2023 13:19

Contributor Author

fchapoton commented Jul 13, 2023

the suggested details have been fixed now

github-actions bot commented Jul 13, 2023

Documentation preview for this PR (built with commit fdae513; changes) is ready! 🎉

tscrim approved these changes

View reviewed changes

Collaborator

tscrim left a comment

LGTM.

tscrim added s: positive review and removed s: needs review labels

vbraun merged commit 41fa630 into sagemath:develop

12 of 13 checks passed

mkoeppe added this to the sage-10.1 milestone

kwankyu removed the s: positive review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment