Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.categories: Update # needs #35945

Merged
merged 43 commits into from
Aug 27, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Jul 12, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

…combinat[modules]' --only-tags --probe=sage.rings.finite_rings --overwrite
…y-tags --overwrite src/sage/categories/discrete_valuation.py
…y-tags --overwrite src/sage/categories/finite_dimensional_lie_algebras_with_basis.py
…rwrite src/sage/categories/finite_dimensional_lie_algebras_with_basis.py
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did my best but may have missed some details in this giant PR...

src/sage/categories/algebras.py Outdated Show resolved Hide resolved
src/sage/categories/category_types.py Outdated Show resolved Hide resolved
src/sage/categories/category_types.py Outdated Show resolved Hide resolved
src/sage/categories/coxeter_groups.py Outdated Show resolved Hide resolved
src/sage/categories/coxeter_groups.py Outdated Show resolved Hide resolved
src/sage/categories/lie_conformal_algebras.py Show resolved Hide resolved
src/sage/categories/manifolds.py Outdated Show resolved Hide resolved
sage: f = lambda part: 2 * s(part.conjugate()) # optional - sage.combinat sage.modules
sage: s._apply_module_endomorphism(s([2,1]) + s([1,1,1]), f) # optional - sage.combinat sage.modules
sage: s = SymmetricFunctions(QQ).schur() # needs sage.combinat sage.modules
sage: f = lambda part: 2 * s(part.conjugate())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s needs sage.combinat sage.modules

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a definition of a lambda function, it does not need the binding of s

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I have made some improvements to the file in 8b8164d

src/sage/categories/morphism.pyx Outdated Show resolved Hide resolved
src/sage/categories/pushout.py Outdated Show resolved Hide resolved
@github-actions
Copy link

Documentation preview for this PR (built with commit f29be5a; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to accept this PR. It improves many parts of the code. Further cosmetic improvements can be done in future PRs. This one is already big enough.

LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 17, 2023

Thank you very much!

mkoeppe added a commit to mkoeppe/sage that referenced this pull request Aug 17, 2023
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 23, 2023
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
- Part of: sagemath#29705
- Cherry-picked from: sagemath#35095
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#35945
Reported by: Matthias Köppe
Reviewer(s): David Coudert, Matthias Köppe
@vbraun vbraun merged commit f186664 into sagemath:develop Aug 27, 2023
12 of 13 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants