Improve method reverse for digraphs #35969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doctests failures in posets/hasse_diagram |
|
Should be ok now. |
|
let me test this one locally |
|
I'm afraid this PR will have many conflicts with #36026, in particular due to the last commit. |
mkoeppe
reviewed
Aug 6, 2023
mkoeppe
reviewed
Aug 6, 2023
mkoeppe
reviewed
Aug 6, 2023
mkoeppe
approved these changes
Aug 6, 2023
|
Documentation preview for this PR (built with commit 05e3ba6; changes) is ready! 🎉 |
|
Thank you. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 11, 2023
We improve method ``reverse`` to ensure that the returned digraph has the same attributes than the original digraph (mutability, multiple edges, loops, vertex positions, etc.). We also add parameter `immutable` to decide if the return graph should have the same setting as the original digraph or forced it to be (im)mutable. On the way, we do minor corrections in method `feedback_edge_set`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35969 Reported by: David Coudert Reviewer(s): David Coudert, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We improve method
reverseto ensure that the returned digraph has the same attributes than the original digraph (mutability, multiple edges, loops, vertex positions, etc.). We also add parameterimmutableto decide if the return graph should have the same setting as the original digraph or forced it to be (im)mutable.On the way, we do minor corrections in method
feedback_edge_set.📝 Checklist
⌛ Dependencies