some care in sage/graphs/domination.py #35982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mkoeppe
reviewed
Aug 4, 2023
mkoeppe
reviewed
Aug 4, 2023
| @@ -730,7 +737,7 @@ def _aux_with_rep(H, to_dom, u_next): | |||
| break | |||
|
|
|||
|
|
|||
| def minimal_dominating_sets(G, to_dominate=None, work_on_copy=False, k=1): | |||
| def minimal_dominating_sets(G, to_dominate=None, work_on_copy=True, k=1): | |||
| r""" | |||
There was a problem hiding this comment.
Should there be a deprecation period for this change of default?
There was a problem hiding this comment.
We could add a deprecation, but here I consider that we fix a bug. The default value of parameter work_on_copy was not consistent with the code: the graph was modified when set to True and a copy was created when set to False.
Furthermore, I think it is an error to modify the input graph without any explicitly action from the user.
mkoeppe
approved these changes
Aug 5, 2023
|
Thank you for the review. |
|
Documentation preview for this PR (built with commit 945e476; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 11, 2023
We do some minor changes in `sage/graphs/domination.py`. The main change is the default value of parameter `work_on_copy` from `False` to `True`. Firstly, it is safer to ensure that the input graph is not modified by default, unless the user asks for such behavior. Secondly, the method was actually working on a copy when the parameter was `False` (wrong order of tests). We also add some tests to show that the methods are robust to vertices with incomparable labels (see sagemath#35902). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35982 Reported by: David Coudert Reviewer(s): David Coudert, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do some minor changes in
sage/graphs/domination.py.The main change is the default value of parameter
work_on_copyfromFalsetoTrue. Firstly, it is safer to ensure that the input graph is not modified by default, unless the user asks for such behavior. Secondly, the method was actually working on a copy when the parameter wasFalse(wrong order of tests).We also add some tests to show that the methods are robust to vertices with incomparable labels (see #35902).
📝 Checklist
⌛ Dependencies