Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preperiodic_points function over rings #35998

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix preperiodic_points function over rings #35998

wants to merge 3 commits into from

Conversation

guojing0
Copy link
Contributor

This PR aims to fix #34095.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@guojing0 guojing0 self-assigned this Jul 28, 2023
@guojing0 guojing0 added this to the sage-10.1 milestone Jul 28, 2023
@bhutz
Copy link

bhutz commented Aug 7, 2023

The underlying issue is not yet addressed here. The call to .dimension() is only valid over rings, so that would need to be called over the fraction field of the base ring.

I'd also suggest a different new example:

P.<x,y> = ProjectiveSpace(ZZ 1)
f = DynamicalSystem_projective([4*x^2 - 7*y^2, 4*y^2])
f.preperiodic_points(1,2)

@guojing0 guojing0 force-pushed the preperiodic branch 2 times, most recently from 67843a6 to 466276c Compare August 14, 2023 13:48
@mkoeppe mkoeppe modified the milestones: sage-10.1, sage-10.2 Aug 20, 2023
@guojing0 guojing0 removed the t: bug label Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Documentation preview for this PR (built with commit b7797f7; changes) is ready! 🎉

@mkoeppe mkoeppe removed this from the sage-10.2 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhutz bhutz Awaiting requested review from bhutz

@EnderWannabe EnderWannabe Awaiting requested review from EnderWannabe

Assignees

@guojing0 guojing0

Labels
c: dynamics s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preperiodic points fails over rings
3 participants
@guojing0 @bhutz @mkoeppe