Implemented two new methods for dynamical semigroups #36041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homogenize, and dehomogenize; have not tested
and dehomogenize
dehomogenize, and multiply method header
- modified __call__ documentation - removed Counter import - line break changes on a couple other methods
…roups over polynomial rings
…d private method _remove_duplicates_of
MatheMagicianPi
force-pushed
the
dsg_ticket3
branch
from
bf59a36
to
f7c0045
Compare
|
A few things to take care of: line 691 add a :: to separate the two tests |
MatheMagicianPi
force-pushed
the
dsg_ticket3
branch
from
dd939d1
to
74f7748
Compare
|
Looks good |
EnderWannabe
approved these changes
Aug 25, 2023
|
Documentation preview for this PR (built with commit 74f7748; changes) is ready! 🎉 |
|
this has broken 2 out of our 3 linters. Bravo.. (or maybe it was one of the other pull requests about dynamical semingroups, anyway..) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The orbit method works like the orbit method in dynamical systems, but instead the point is evaluated on using a dynamical semigroup.
The specialization method returns a dynamical semigroup defined by the specialization of the generators.
This is part of issue #35954
📝 Checklist
⌛ Dependencies
#35947
#35988