-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up the creation of submatrices of Matrix_modn_dense_template
matrices
#36059
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
832be74
sparse iter and _copy_zero
ae6a7dd
calloc
19608a6
redefine _from_rows and _from_rows_and_columns
3596abb
Merge branch 'sagemath:develop' into creation_matrix
marizee f724b21
add arg zeroed_alloc cinit
91b58ee
add zeroed_alloc=False
6701ef4
Merge branch 'sagemath:develop' into submatrices
marizee 4b24dff
add _from_colums in modn_template
af0de6b
removed _from_rows_and_columns from submatrix
f3bcb78
removed comments
ae2fca6
removed extra blank lines
7b6c79e
Merge branch 'sagemath:develop' into creation_matrix
marizee bd431d3
branch update
78846ca
add missed zeroed_alloc
6db8d9f
remove _matrix calloc
2deabdd
Merge branch 'sagemath:develop' into submatrices
marizee 513a5b5
Merge branch 'sagemath:develop' into creation_matrix
marizee c3f81fd
fix typo
c9a2550
add contiguous block of rows case
f28b6c2
correct submatrix
3ab7db8
_matrix in matrix_from_rows
02def11
add suggested _matrix
f42998b
fixed merge conflicts
a52a33f
missing import
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines could be kept, under a condition
if col == 0 and ncols == self._ncols
. This would make the copying a bit faster (singly memcpy) in this situation where one wants to retrieve a (contiguous) block of complete rows.