Correct typo in class name of Polynomial_ZZ_pEX in .pxd file
#36071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit f4111dd; changes) is ready! 🎉 |
fchapoton
approved these changes
Aug 16, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 23, 2023
…n `.pxd` file
<!-- ^^^^^
Corrects a typo in the cython definition of Polynomial_ZZ_pEX
-->
Currently the cpython definition of within
`/sage/rings/polynomial/polynomial_zz_pex.pxd` exports the class name
`Polynomial_ZZ_pX` instead of `Polynomial_ZZ_pEX`.
At the moment, if a user requires the `Polynomial_ZZ_pEX` within a
`.pyx` file, they must perform the following import:
```
from sage.rings.polynomial.polynomial_zz_pex cimport Polynomial_ZZ_pX as
Polynomial_ZZ_pEX
```
Correcting the typo in the changed file allows the import to be simply
```
from sage.rings.polynomial.polynomial_zz_pex cimport Polynomial_ZZ_pEX
```
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
URL: sagemath#36071
Reported by: Giacomo Pope
Reviewer(s): Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the cpython definition of within
/sage/rings/polynomial/polynomial_zz_pex.pxdexports the class namePolynomial_ZZ_pXinstead ofPolynomial_ZZ_pEX.At the moment, if a user requires the
Polynomial_ZZ_pEXwithin a.pyxfile, they must perform the following import:Correcting the typo in the changed file allows the import to be simply
📝 Checklist